Jump to content

fabiosun

Recommended Posts

  • Supervisor
On 6/30/2021 at 10:17 PM, Arrakis said:

@iGPU

Wonderful job for simplifying the patches.

I am using your patch except the last two.

The job done is so good that I don't even need the argument : cpu_topology_sort -disable _x86_validate_topology  in the garbage 😄

I envy your talent in this area.

 

----------

 

 

@Arrakis

Now is also more clear why (about topology):

ProvideCurrentCpuInfo did the job

1376596308_Screenshot2021-07-12at9_08_58PM.thumb.png.9b7d97e5536c27a36e0b87a1245fe7d7.png

Edited by fabiosun
pictures added
Link to comment
Share on other sites

  • Supervisor

Without making any kind of controversy, let me tell you to take a look at this plist and if you want,

try to adapt it to the bootloader you use and remember also patch 0 has a value (1F) for my 3970x, you must adapt to your cores cpu number.

all patches used are public and available

patch 0 later had some adjustments, in particular on the masks and on the count brought to 1

these adjustments are not yet published by the author, but are not necessary to make various modern systems work

 

 the patch published by algrey on insanely mac, allows you to remove several "XLNC" patches

In the usual spirit that has always distinguished us, if you want to try them, if they don't work for you post a debug ...

you will not believe it .. but this thread is also read by people who then solve the problems in the bootloaders 🙂

 

 

 

@carlo_67it should work also on your platform 😉

Mario* thanks you for trying the previous solution

 

 

UPDATE 17-07-2021:

 

 

  • +1 1
Link to comment
Share on other sites

  • Moderators
16 hours ago, carlo_67 said:

Clover 12 Patch, Opencore, 9 Patch start Bigsur e thanks to Mario 😇

 

indeed in Clover it does not even serve to enable Quirk

 

 

 

 

1564600152_Schermata2021-07-12alle19_21_06.thumb.png.9a6bde46162f61b4970c05d035593b98.png

 

 

Schermata 2021-07-12 alle 19.10.29.png

 

Amarioooooooo 😄

  • Like 1
  • Haha 1
  • whahahah 1
Link to comment
Share on other sites

  • Supervisor

1049119044_Schermata2021-07-14alle20_19_24.thumb.png.b90b8fd41f60f5e8234237440458f87f.png

also clover 🙂

but it needs more patches

 

@Ploddlesit is not a special tool 🙂

it is a quirk and I have talked time ago here

AMD OSX Patches maintainer have done a pull request to add some patches to this quirks all we have in open core available

I have had an opencore debug boot loader with all these patches inserted in it
Only one patch is not public otherwise I 
wouldn't be able to boot in Clover Booloader

  • Like 1
Link to comment
Share on other sites

  • Supervisor

1178931358_Schermata2021-07-14alle20_34_52.thumb.png.b1e106de0a93a90de5e33a478f5d0753.png

 

these are patches AMD OSX maintainer would like to insert in a quirk with Shaneee pull request, with these you can bypass a lot of patches enabling that quirk

If opencoredevs accept it would be possible to to reduce the list of visible patches in Kernel/patch section

 

 

  • Like 1
Link to comment
Share on other sites

  • Moderators

On a different topic (for those of us still stuck with M-ß1 and old patches...:classic_wink:), here is a way to adjust the labelling of the NVMeExpress setting in SystemInfo using a kext file (and then no injection is needed within DeviceProperties).

 

This kext file was created by apfelnico who posted it here (after his original post here). I've taken liberty in renaming the file (to better describe its function) and adding another section for TRX40 inside the file. You will have to change the settings for your drives; the uploaded file is for my drives and yours are probably different.

 

[But truly it is not dependent on the mobo, but rather simply on which NVMe drives are in your system as shown below. This means that the "X299" section can be deleted and also means that the "TRX40" section title I made, can be renamed to something else like "NVMeDrives". In fact, this is exactly what I did in the update to the uploaded file: the image of the Info.plist section that says "TRX40" now is "NVMeDrives".]

 

Basically, this kext injects your NVMe drive data so that Apple recognizes it as being an Apple SSD Controller rather than a Generic Controller. This is probably mostly cosmetic, but under the hood, who knows if Apple doesn't treat the controller differently?

 

Before using the kext (note "Generic SSD Controller" in spoiler):

Spoiler

BeforeUsingNVMeControllerFix.thumb.png.395a4de3572e71cb9c87dea83d885dd6.png

 

After using the kext, now "Generic" is changed to "Apple SSD Controller":

AfterUsingNVMeControllerFix.thumb.png.9a248ff53cbfac3d752fa6a119514705.png

 

 

 

How to use NVMeControllerFix

 

1) To adjust, open the kext and edit the Info.plist file (see Spoiler below):

 

Spoiler

 

A) First, open kext by right-clicking on kext and selecting "Show Package Contents":

 

OpenKextContents.png.cd133e79faa0c0a87d11e23ddeee99cc.png

 

B) Next, you'll see:

 

Contents-Info.thumb.png.c31c1230a5e5362d31bdb25a163dff60.png

 

C) Then double-click and open Info.plist in your favorite editor. You'll want to edit the IOPCIPrimaryMatch section. You can even duplicate the TRX40 or X299 section and edit that duplicate, using that section for other mobos that you use.

 

NVMeControllerFix-Info.thumb.png.40c20a58e936ed57af5ef9634ee3aed5.png

 

 

 

 

2) After following steps in above Spoiler, you'll want to edit the IOPCIPrimaryMatch section with data collected using HackCheck.

 

Specifically, using the pop-up shown in the leftmost red box, rotate among your NVMe drives, copying the Device-id and Vendor-id to the IOPCIPrimaryMatch section inside of the Info.plist file. The data is entered as "0x[Device-id][Vendor-id]" (eg, 0x50181987 in the example) with spaces between each NVMe drive in your system.

 

HackCheck:                                                                                                                                             Info.plist:

HackCheckDisk-kextAdjust.thumb.png.463507f2f44252c73c5fa2c96bba32bc.png

 

 

3) Save the Info.plist file and add this kext file to your Config/Kernel/Add section.

 

Kernel-Add-NVMeControllerFix.thumb.png.db2c01d9b26af5b1d21810f6d135098b.png

 

 

 

 

 

NVMeControllerFix.kext.zip

Edited by iGPU
Updated uploaded kext file 15 July
  • Like 1
  • Thanks 4
Link to comment
Share on other sites

  • Supervisor

thank you @iGPU

it works also in M-ß3 😉

 

with kext:

560587372_Screenshot2021-07-15at3_56_30PM.thumb.png.6595dfe89c129fede691ed58a11e6f3f.png

 

without kext:

 

1339686514_Screenshot2021-07-15at4_36_56PM.png.78bd51dfbea770cca97de2ab04f0bfa4.png

 

Nvme in this pictures is on a pciEx card and it is seen by default as Apple SSD Controller

Or Samsung 960 pro is more compatible with apple?

IDK

Edited by fabiosun
with/without kext
Link to comment
Share on other sites

  • Moderators
1 hour ago, fabiosun said:

thank you @iGPU

it works also in M-ß3 😉

 

with kext:

560587372_Screenshot2021-07-15at3_56_30PM.thumb.png.6595dfe89c129fede691ed58a11e6f3f.png

 

without kext:

 

1339686514_Screenshot2021-07-15at4_36_56PM.png.78bd51dfbea770cca97de2ab04f0bfa4.png

 

Nvme in this pictures is on a pciEx card and it is seen by default as Apple SSD Controller

Or Samsung 960 pro is more compatible with apple?

IDK

 

I think your Samsung is an SSD drive, the others are NVMe. This kext is only needed for NVMe drives.

Link to comment
Share on other sites

  • Moderators
3 hours ago, fabiosun said:

no @iGPUit is a 960 pro 1Tb MVME

Mounted on a pciex card as you can see in this bad picture :

847851149_Screenshot2021-07-15at6_16_22PM.png.a70e87e2f39c14351e026cb6ce88775b.png

1637234289_Screenshot2021-07-15at6_17_43PM.png.f8093ec0a1cae07e55d93c75e7029569.png

 

I doubt it's a Samsung benefit, but probably related to pciEx card connection. The obvious way to test, is to exchange the Samsung with one of the Sabrent NVMe.

 

But I wouldn't bother: too much work. I'd just use kext for the internal NVMe drives.

 

Link to comment
Share on other sites

21 hours ago, iGPU said:

This is probably mostly cosmetic, but under the hood, who knows if Apple doesn't treat the controller differently?

This needs confirmation, since if this is valid it could be easily implemented in NVMeFix.

 

For those who use Samsung drives, I highly recommend either not to use macOS with them or to disable TRIM completely since a fancy rename won't give back support for IONVMeFamily - macOS doesn't like Phoenix controlles which unfortunately affect every Samsung NVMe since forever basically...

 

 

@iGPU

I suggest to open a feature request/discussion on acidanthera bugtracker on the rename from Generic to Apple SSD

8 hours ago, fabiosun said:

Samsung 960 pro is more compatible with apple?

This unfortunately is false, check out this article:

 

https://github.com/dortania/bugtracker/issues/192

Edited by A23SS4NDRO
the issue was the 192, not 196
Link to comment
Share on other sites

  • Supervisor

@A23SS4NDROmy was a question not a statement 

I have seen your link

i boot with 960 pro in OS X it seems I have not any delay

i will check better

maybe ten seconds from boot menu to login page 

for trim I always used default custom config posted in opencore doc 

Link to comment
Share on other sites

2 hours ago, fabiosun said:

i boot with 960 pro in OS X it seems I have not any delay

Check the test from the issue linked before, and try the different SetApfsTimeout

 

Unfortunately it's not specific to a single NVMe, but all Samsung are broken with IONVMeFamily - hence not recommended (since you can have issues with TRIM if it's kept enabled)

The issue with Samsung drives is documented here:

 

 

https://github.com/acidanthera/OpenCorePkg/blob/c5285973bcfd45908c62487cf2e318aa0328af3b/Docs/Configuration.tex#L2616

 

 

and also the additional wear on the drive that is the result of this incompatibility

  • Ok 1
Link to comment
Share on other sites

  • Supervisor

hey guys....maybe you have missed something... 😛

 

b2/b3 patch has been published....

only read me is old....

secret was revealed by Shaneee a day ago or more 🙂 🙂

 

Schermata_2021-07-16_alle_12_05_05.thumb.png.d46b05ef576862d9f065ec3553622784.png

 

the secret is gone 🙂 🙂 🙂

 

  • Like 1
  • +1 1
Link to comment
Share on other sites

  • Supervisor

and this is my patches list now to boot from Big Sur to Monterey beta 3:

 

Patches_BS_MR_1_2_3.plist.zip

 

You have to add (in initial position this):

Force cpuid_cores_per_package

Screenshot_2021-07-16_at_5_21.36_PM-1.png.5b97665c5dd850d29936f801abd13938.png

 

from @Shaneee PR or with old one published on insanelyMac by Algrey (with cores number -1)

 

now without -1 for your cores number (not tested by me because i am using a different way)

so core count with above patch is:

 

32 cores - 3970x  =2 0

24 cores - 3960x = 18

16 cores - 3950x = 10

10 cores = 0A

8 cores = 08

6 cores = 06

 

Update:

I prefer to use old patch for "Force Cupid_cores_per_package"

but for someone could be fine to use it also

 

Update:2

Patches in PR works also in clover bootloader , it was a error of mine (missing Procedure on it)

Edited by fabiosun
Update 2 with further infos
  • Like 1
Link to comment
Share on other sites

2 hours ago, fabiosun said:

and this is my patches list now to boot from Big Sur to Monterey beta 3:

 

Patches_BS_MR_1_2_3.plist.zip 1.74 kB · 4 downloads

 

You have to add (in initial position this):




Force cpuid_cores_per_package

from @Shaneee PR or with old one published on insanelyMac by Algrey (with cores number -1)

 

now without -1 for your cores number (not tested by me because i am using a different way)

so core count with above patch is:

 

32 cores - 3970x  =2 0

24 cores - 3960x = 18

16 cores - 3950x = 10

10 cores = 0A

8 cores = 08

6 cores = 06

 

Follow your instruction and adapted with your config-patch.plist it still can not boot beta2 or beta3 of Monterey.

It can boot 10.13.x~12.0 beta1 only.

config.plist.zip

Edited by jsl2000
Link to comment
Share on other sites

  • fabiosun changed the title to [Discussion] - TRX40 Bare Metal - Vanilla Patches

Create an account or sign in to comment

You need to be a member in order to leave a comment

Create an account

Sign up for a new account in our community. It's easy!

Register a new account

Sign in

Already have an account? Sign in here.

Sign In Now
  • Recently Browsing   0 members

    • There are no registered users currently online
×
×
  • Create New...

Important Information

We have placed cookies on your device to help make this website better. You can adjust your cookie settings, otherwise we'll assume you're okay to continue.